refactor(android): migrate DashUtil to Kotlin #4077
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seyedmostafahasani
requested review from
YangJonghun,
freeboub and
KrzysztofMoch
freeboub
requested changes
Aug 11, 2024
| object DashUtil { | ||
| @JvmStatic | ||
| fun loadManifest(dataSource: DataSource, uri: Uri): DashManifest { | ||
| TODO("Implement the logic to load and return the DashManifest") |
There was a problem hiding this comment.
This is a stub file, you don't need the todo ...
freeboub
approved these changes
Aug 12, 2024
KrzysztofMoch
approved these changes
Aug 12, 2024
|
We have an issue excluding the Kotlin file in build.gradle.Please don’t merge this PR until it is fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrate DashUtil to Kotlin
Motivation
Migrate the codebase from Java to Kotlin
Changes
Test plan