Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/#206 msw 실행 시점 변경 #207

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Fix/#206 msw 실행 시점 변경 #207

merged 2 commits into from
Oct 31, 2023

Conversation

navyjeongs
Copy link
Member

@navyjeongs navyjeongs commented Oct 30, 2023 •
edited
Loading

🤠 개요

💫 설명

개발모드인지 확인하고 개발모드가 아니라면 원래 컴포넌트를 바로 렌더링해요.
만약 개발모드라면 msw를 init한 후 컴포넌트를 렌더링할 수 있도록 변경했어요.

📷 스크린샷 (Optional)

  • 기존, 렌더링 이후 msw init 실행
Screenshot 2023-10-30 at 10 54 00 PM
  • 수정 후, msw init 이후 렌더링
Screenshot 2023-10-30 at 11 12 05 PM

@navyjeongs navyjeongs added the 🛠 Fix 프로젝트 버그 수정 이슈 label Oct 30, 2023
@navyjeongs navyjeongs self-assigned this Oct 30, 2023
@navyjeongs navyjeongs linked an issue Oct 30, 2023 that may be closed by this pull request
Fix: MSW 실행시점 변경 #206
Closed
1 task
pp449
pp449 approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@pp449 pp449 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이렇게 해결할 수 있었군요! ✅

@navyjeongs navyjeongs merged commit 5f7ebf1 into dev Oct 31, 2023
1 check passed
@navyjeongs navyjeongs deleted the Fix/#206 branch October 31, 2023 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pp449 pp449 pp449 approved these changes

Assignees

@navyjeongs navyjeongs

Labels
🛠 Fix 프로젝트 버그 수정 이슈
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix: MSW 실행시점 변경
2 participants
@navyjeongs @pp449