Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/#198: 채널 보드 삭제 기능 추가 #199

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Feat/#198: 채널 보드 삭제 기능 추가 #199

merged 4 commits into from
Oct 30, 2023

Conversation

pp449
Copy link
Member

@pp449 pp449 commented Oct 28, 2023

🤠 개요

  • closes: Feat: 채널 보드 삭제 추가 #198
  • 채널 보드 삭제 기능을 추가했어요
  • 채널 보드가 삭제되면 마지막에 방문한 board 를 빈값으로 설정하여 결국 제일 첫번째 보드를 가리키게 돼요

💫 설명

📷 스크린샷 (Optional)

dd.mov

@pp449 pp449 added the ✨ Feat 기능 개발 label Oct 28, 2023
@pp449 pp449 requested a review from navyjeongs October 28, 2023 09:47
@pp449 pp449 self-assigned this Oct 28, 2023
navyjeongs
navyjeongs approved these changes Oct 29, 2023
View reviewed changes
Copy link
Member

@navyjeongs navyjeongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good~
근데 테스트가 또 실패하네요

@pp449
Copy link
Member Author

pp449 commented Oct 30, 2023

Good~ 근데 테스트가 또 실패하네요

채널 보드쪽에 타입 문제가 있었는데 수정했습니다~

@pp449 pp449 merged commit f965e9f into dev Oct 30, 2023
1 check passed
@pp449 pp449 deleted the Feat/#198 branch October 30, 2023 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navyjeongs navyjeongs navyjeongs approved these changes

Assignees

@pp449 pp449

Labels
✨ Feat 기능 개발
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: 채널 보드 삭제 추가
2 participants
@pp449 @navyjeongs