Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: 헤더 드롭다운 메뉴 추가 #134

Merged
merged 1 commit into from
Sep 16, 2023
Merged

Feat: 헤더 드롭다운 메뉴 추가 #134

merged 1 commit into from
Sep 16, 2023

Conversation

navyjeongs
Copy link
Member

🤠 개요

💫 설명

  • 로그인 되어있을 땐 이름과 이미지를 클릭하면 드롭다운 메뉴를 만들었어요.
    • 현재 로그아웃을 하면 서버에 로그아웃을 요청하고 cookie에서 accessToken과 refreshToken을 제거했는데 profileContext를 초기화 하지 않았어요.
    • profileContext의 경우 앞선 pr에서 수정된 부분이 있어서 해당 pr이 머지되면 초기화 기능을 추가할게요.

📷 스크린샷 (Optional)

ㅇㅇㅇㅇ

@navyjeongs navyjeongs added the ✨ Feat 기능 개발 label Sep 10, 2023
@navyjeongs navyjeongs requested a review from pp449 September 10, 2023 09:37
@navyjeongs navyjeongs self-assigned this Sep 10, 2023
@navyjeongs navyjeongs linked an issue Sep 10, 2023 that may be closed by this pull request
Feat: 헤더에 이름 클릭 시 드롭다운 메뉴 추가 #128
Closed
2 tasks
pp449
pp449 approved these changes Sep 16, 2023
View reviewed changes
Copy link
Member

@pp449 pp449 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM~

@navyjeongs navyjeongs merged commit e51caf5 into dev Sep 16, 2023
1 check passed
@navyjeongs navyjeongs deleted the Feat/#128 branch September 16, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pp449 pp449 pp449 approved these changes

Assignees

@navyjeongs navyjeongs

Labels
✨ Feat 기능 개발
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: 헤더에 이름 클릭 시 드롭다운 메뉴 추가
2 participants
@navyjeongs @pp449