Abstractions project #413
Merged
Abstractions project #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CPColin
previously approved these changes
Oct 24, 2023
CPColin
previously approved these changes
Oct 24, 2023
Vivelin
previously approved these changes
Oct 25, 2023
I guess with as many properties as there are here, I suppose abstract classes would make more sense, yeah. |
|
Switched to abstract classes for AutoTracker, Tracker, and the SpeechRecognitionService (due to the event - interfaces don't seem to work well with events that aren't used). While I was at it, I cleaned up a lot of the warnings that had cropped up in builds since the .net 7 upgrade, most of which were in regards to code being only accessible on Windows. |
Vivelin
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new abstractions project to hold interfaces and whatnot. For now, I just moved some of the Tracker stuff in there. The game mode interface will go in there, and we can probably slowly pull other things in there over time.