-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show estimated images uncompressed size #189
Conversation
Adding a message to the use when starting an image download @QU35T-code @Dramelac any idea to why the download size (left arrow in the screenshot above) is not the same as the one shown during the download process (right arrow in the screenshot above) ? |
No i don't know, but i wouldn't be surprise if docker mess things up somewhere, like not including metadata in the size count or something like this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last update and it should be good to go
Previously, the wrapper would show remote image compressed size when they were not installed.
This is because the real, uncompressed, size cannot be fetched through Dockerhub and because the compression factor is not publick knowledge.
I downloaded a few images and did the math
The comp. factor goes up to x2.6.
Taking this into account, I modified the wrapper to show that estimated size instead as it makes more sense for the end user to know how much room it'll take on disk. This replaces the "compressed download" size on the images list available through (for instance)
exegol info
.When increasing verbosity, both "compressed download" size and "real size on disk" are shown