Using eth0 interface for desktop service when using bridge

ThePorgs · Oct 14, 2023 · a4c07b2 · a4c07b2
1 parent f80e7e2
commit a4c07b2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/exegol/model/ContainerConfig.py b/exegol/model/ContainerConfig.py
@@ -494,8 +494,9 @@ def enableDesktop(self, desktop_config: str = ""):
                 self.addEnv(self.ExegolEnv.desktop_host.value, self.__desktop_host)
                 self.addEnv(self.ExegolEnv.desktop_port.value, str(self.__desktop_port))
             else:
-                # FIXME : we are exposing the desktop on the network the container is in. Ex: if we're doing VPN, we're opening the desktop through it's network
-                self.addEnv(self.ExegolEnv.desktop_host.value, "0.0.0.0")
+                # If we do not specify the host to the container it will automatically choose eth0 interface
+                # TODO ensure there is an eth0 interface
+                # Using default port for the service
                 self.addEnv(self.ExegolEnv.desktop_port.value, str(self.__default_desktop_port.get(self.__desktop_proto)))
                 # Exposing desktop service
                 self.addPort(port_host=self.__desktop_port, port_container=self.__default_desktop_port[self.__desktop_proto], host_ip=self.__desktop_host)

diff --git a/exegol/utils/imgsync/entrypoint.sh b/exegol/utils/imgsync/entrypoint.sh
@@ -90,7 +90,7 @@ function run_cmd() {
 function desktop() {
   if command -v desktop-start &> /dev/null
   then
-      echo "Starting Exegol [green]desktop[/green] with [blue]${DESKTOP_PROTO}[/blue]"
+      echo "Starting Exegol [green]desktop[/green] with [blue]${EXEGOL_DESKTOP_PROTO}[/blue]"
       desktop-start &>> ~/.vnc/startup.log  # Disable logging
       sleep 2  # Waiting 2 seconds for the Desktop to start before continuing
   else