fixed weather and removed infinite alert bug #175
Conversation
| @@ -124,15 +124,14 @@ function baseWeather () { | |||
| IMAGES["Custom"].onerror = () => { | |||
| if (IMAGES["Custom"]._errorSrc == null) { | |||
| IMAGES["Custom"]._errorSrc = page.get("bR20cfg_weatherTypeCustom1"); | |||
| alert(`Custom weather image "${IMAGES["Custom"].src}" failed to load!`); | |||
| console.log(`Custom weather image "${IMAGES["Custom"].src}" failed to load!`); | |||
There was a problem hiding this comment.
should be at least a .warn if not a .error
| @@ -30,7 +30,7 @@ function initHTMLpageWeather () { | |||
| </div> | |||
| <div class="pagedetails__subheader"> | |||
| <h4>Custom type</h4> | |||
| <a class="tipsy-w showtip pictos" original-title="Input URL to your PNG when "Custom" is selected above">?</a> | |||
| <a class="tipsy-w showtip pictos" original-title="Input URL to your PNG when "Custom" is selected above. Broken URLs will appear as rain.">?</a> | |||
There was a problem hiding this comment.
hm, this is a bit subtle, and sticking the "solution" in the tooltip isn't great. Maybe we grab the classic missing texture image and chuck it in as the fallback?
| @@ -32,6 +32,7 @@ function baseWeather () { | |||
| "Waves": new Image(), | |||
| "Ripples": new Image(), | |||
| "Blood Rain": new Image(), | |||
| "Custom": new Image(), | |||
| }; | |||
| IMAGES.Rain.src = "https://i.imgur.com/lZrqiVk.png"; | |||
There was a problem hiding this comment.
come to think of it, do we have these in the repo anywhere? If not, we're at risk of them disappearing someday
Might be best to commit them to e.g. img/weather/* and reference the raw.github. ... URLs here (i.e. https://raw.githubusercontent.com/TheGiddyLimit/betterR20/development/img/weather/rain.png)
| @@ -32,6 +32,7 @@ function baseWeather () { | |||
| "Waves": new Image(), | |||
| "Ripples": new Image(), | |||
| "Blood Rain": new Image(), | |||
| "Custom": new Image(), | |||
There was a problem hiding this comment.
what's the reasoning behind adding the Custom image here/removing the "cleanup when unused" step below..?
Made weather work again and fixed a bug that gave infinite alerts if you did custom images for weather without a url.