Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add list of reactions #11

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Add list of reactions #11

wants to merge 14 commits into from

Conversation

TheEssem
Copy link
Owner

@TheEssem TheEssem commented Jan 25, 2024 •
edited
Loading

Work in progress. Currently only done on the API; working on exposing it in the UI.

This separates the status reaction serializer from the announcement reaction serializer to avoid breaking announcement reactions/exposing more info than needed.

To Do:

  • Show what emoji each user reacted with in list
  • Filter by emoji in API
  • Test with remote reactions/users

I'm really not too sure about the quality of this code, which is why I'm making a PR first...

@TheEssem TheEssem force-pushed the wip/reaction-list branch 2 times, most recently from 15e43b6 to 7a20541 Compare January 28, 2024 20:43
@TheEssem TheEssem marked this pull request as ready for review January 28, 2024 21:27
@TheEssem TheEssem mentioned this pull request Feb 7, 2024
Open
@TheEssem
Copy link
Owner Author

@VyrCossont This should (hopefully) be reviewable now; note that the /reactions endpoint differs from the Firefish/Akkoma implementations in a few ways (reactions are paginated/sorted in descending order, each reaction is per-user, filtering is done through a query param). Remote users in the API responses/list UI are still untested because I don't have a proper environment for federation testing, but they should work in theory.

@github-actions GitHub Actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@VyrCossont
Copy link

Thank you! I'll take a look this weekend.

@github-actions GitHub Actions
Copy link

This pull request has resolved merge conflicts and is ready for review.

@ShadowJonathan
Copy link

ShadowJonathan commented Feb 10, 2024 •
edited
Loading

I'm mentioning glitch-soc#2462 real quick so there's a link to this somewhere other than the fedi post

@github-actions GitHub Actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions GitHub Actions
Copy link

This pull request has resolved merge conflicts and is ready for review.

@github-actions GitHub Actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions GitHub Actions
Copy link

This pull request has resolved merge conflicts and is ready for review.

@github-actions GitHub Actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@TheEssem TheEssem force-pushed the wip/reaction-list branch from 605d936 to b65dea1 Compare March 11, 2024 18:19
@github-actions GitHub Actions
Copy link

This pull request has resolved merge conflicts and is ready for review.

@github-actions GitHub Actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@TheEssem TheEssem force-pushed the wip/reaction-list branch from 661001a to 190bdc1 Compare May 24, 2024 15:50
@github-actions GitHub Actions
Copy link

This pull request has resolved merge conflicts and is ready for review.

@github-actions GitHub Actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@TheEssem TheEssem force-pushed the wip/reaction-list branch from 190bdc1 to d437420 Compare July 17, 2024 19:59
@github-actions GitHub Actions
Copy link

This pull request has resolved merge conflicts and is ready for review.

@TheEssem TheEssem force-pushed the wip/reaction-list branch 2 times, most recently from 218f6e1 to 03a3dff Compare November 7, 2024 21:39
@github-actions GitHub Actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rebase needed 🚧
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheEssem @VyrCossont @ShadowJonathan