-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --bundle
option to web
commands
#195
Conversation
2ed77bf
to
abea5e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and it works! (Even on Bevy 0.11, which was the only project I have available at the time.)
Once you address the non-nits, I'll approve and merge. :)
@BD103 I think I addressed all comments, let me know if you notice anything else! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
Objective
Closes #68.
Adds the
--bundle
argument to thebevy build web
andbevy run web
commands.This will pack all files needed for the web into a single folder.
The location of the bundle will be
target/bevy_web/{profile}/{binary}
.This makes it a lot easier to deploy the app e.g. on itch.io or a generic web server.
It also unblocks the switch from
trunk
to the Bevy CLI for the Bevy 2D template: TheBevyFlock/bevy_new_2d#312.Solution
--bundle
option to the build and run web commands.WebBundle
enum, which can represent a linked or packed bundle: