Fix wrapping env vars #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pawel Czarnecki <[email protected]>
This reverts commit c3ccdb8.
Signed-off-by: Pawel Czarnecki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues with escaping environment variables with spaces, e.g.
"DIE_AREA=0 0 400 400".The most important change here is the transition from the usage of
run_binary()rule from Aspect Bazel Lib to simple native genrules. This change was required because of a bug in the implementation ofrun_binary()rule inAspect Bazel Lib(see bazel-contrib/bazel-lib#666). The implementation from Bazel Skylib is also prone to this bug and additionally has problems with expandingRULEDIRbuilt-in make variable (see bazelbuild/bazel-skylib#438).Additionally, a slightly modified version of
wrap_args()helper function which wraps contents of env vars with spaces into single quotes was also reintroduced to the codebase.CC @oharboe