Move BaseResource to root to avoid loops

ThanatosGit · Oct 14, 2024 · 8682d77 · 8682d77
1 parent 70b294e
commit 8682d77
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/pyproject.toml b/pyproject.toml
@@ -81,12 +81,13 @@ select = [
     "PLC0208",  # iterating over set is also not deterministic, so we shouldn't do that!
 
     "PLE",
-    "PLR0402", "PLR1701", "PLR1711", "PLR1722", "PLR0206",
-    "PLR0133", "PLR0124",
+    "PLR0402", "PLR1711", "PLR1722", "PLR0206", "PLR0133", "PLR0124",
     "PLW",
+    "SIM101",
 ]
 extend-ignore = [
     "ISC001",  # may cause conflicts with formatter
+    "PLW2901",  # `for` loop variable `key` overwritten by assignment target
 ]
 
 [tool.ruff.lint.isort]

diff --git a/..._data_structures/formats/base_resource.py → ...y_engine_data_structures/base_resource.py b/..._data_structures/formats/base_resource.py → ...y_engine_data_structures/base_resource.py
@@ -2,14 +2,12 @@
 
 import typing
 
-from construct import Construct, Container
-
-from mercury_engine_data_structures.game_check import Game
-
 if typing.TYPE_CHECKING:
     import typing_extensions
+    from construct import Construct, Container
 
     from mercury_engine_data_structures.file_tree_editor import FileTreeEditor
+    from mercury_engine_data_structures.game_check import Game
 
 
 class BaseResource:
@@ -24,7 +22,7 @@ def __init__(self, raw: Container, target_game: Game, editor: FileTreeEditor | N
 
     @classmethod
     def construct_class(cls, target_game: Game) -> Construct:
-        raise NotImplementedError()
+        raise NotImplementedError
 
     @classmethod
     def parse(cls, data: bytes, target_game: Game, editor: FileTreeEditor | None = None) -> typing_extensions.Self: