Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to/from array conversions for windows #103

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix to/from array conversions for windows #103

wants to merge 2 commits into from

Commits on May 21, 2023

  1. Split common_test

    @droppingin
    droppingin committed May 21, 2023
    Configuration menu
    Copy the full SHA
    db3e080 View commit details
    Browse the repository at this point in the history

  2. Fix to/from array conversions for windows 

    uint is at least 32 bit integer, according to the standard.
on windows, the uint has 64 bits, as in linux, but:
C.sizeof_ulong is 0x4 on windows.
ASAN does not like that.
but even if the value is stored, the code can't read it properly,
because bytesToUlong checks
if sliceSize > C.sizeof_ulong
    @droppingin
    droppingin committed May 21, 2023
    Configuration menu
    Copy the full SHA
    b748786 View commit details
    Browse the repository at this point in the history