Fine tune parameter controls label format #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liancheng
force-pushed
the
param-control-label
branch
from
d493678
to
c0e0f1a
Compare
liancheng
commented
Aug 2, 2024
| else: | ||
| names = Text(" / ", style="dim").join([Text(n) for n in name]) | ||
| text = Text.from_markup( | ||
| f"{names}[dim]{' multiple' if multiple else ''} {type.name}[/] {' [b red]*[/]required' if is_required else ''}" |
There was a problem hiding this comment.
The {name} part here is a bug as Text.plain is used when a Text object is referenced in an f-string, so we lose the dim style in the rendered result.
However, it looks better without the dim, so I did not include the dim in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored label generation of parameter controls to have consistent white spacing between label segments.
Here is a comparison of before and after this PR: