feat: Add support for Typer #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmcgugan
reviewed
May 22, 2023
evanmags
force-pushed
the
main
branch
3 times, most recently
from
b05c7fe
to
49e8807
Compare
|
Removed the dependency requirement on typer and created an extra for it. This pattern of I'm weighing the benefits of being able to add this to a single command in typer, as the pattern set out in the docs would be to create a nested app for that. |
darrenburns
previously requested changes
May 25, 2023
Fix the description for Typer support. Signed-off-by: Michael Gielda <[email protected]>
|
Hi @darrenburns - I made a PR against @evanmags' branch fixing the docs. When he merges that, your review will be included; is there anything else that needs to be done to make this land? |
* upstream/main: (44 commits) Downgrade macos runner Bump actions versions to latest Update textualize dependency spec Update README.md fix: prefix binding actions with app namespace Tweak the styling to make the sidebar less greedy Strip trailing whitespace from the CSS file Relock Bump to Textual 0.54 Add import Fix typo Remove '+ value' button from multi choice widget. Do not treat Select.BLANK as a supplied value Swap order of parameter explanations in README Create LICENSE version bump Ensure custom command names dont appear in sidebar fix: fixed command info when no docstring is present fix: fixed help_text if self.schema.help is none Expect at least one space ...
daneah
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @willmcgugan, You don't have a CONTRIBUTING.md on this repo, so I'm not sure if/how I can contribute to this, but these are the changes I made on my fork to get Trogon working in my Typer app. I have a few TODOs below but would like your input for desired usage and best practice. Thank you 🙏
TODO: