Don't apply Input "select on focus" behaviour when app is focused #5379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think so. At least not currently. But you can find the login in |
…ette-dont-select-on-focus
Added a new argument `from_app_focus` to the Focus event class to indicate whether the focus event was triggered by the application regaining focus or by user interaction within the Textual app. Updated the constructor to initialize this new attribute.
… App regaining focus or whether they're a standard focus.
…d from an app focus event.
darrenburns
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the browser for example, an input element will only select its content if I tab to it. If I alt+tab to another app then alt+tab back, it doesn't select everything.
This updates Textual to match this behaviour.
Added
from_app_focustoFocusevent to indicate if a widget is being focused because the app itself has regained focus or not Don't apply Input "select on focus" behaviour when app is focused #5379Changed
Inputwill now only be automatically selected when the widget is focused by the user, not when the app itself has regained focus (similar to web browsers). Don't apply Input "select on focus" behaviour when app is focused #5379