Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak to select #5265

Closed
wants to merge 4 commits into from
Closed

tweak to select #5265

wants to merge 4 commits into from

Conversation

willmcgugan
Copy link
Collaborator

@willmcgugan willmcgugan commented Nov 20, 2024

Trying to fix the issue where the select drop-down sometimes appears blank.

I think it may be because of race condition in OptionList, where the order of messages may cause a failure to render.

This may work around it. Rather than display:none I've used visibility:hidden. This is because visibility:hidden will still go through a layout procedure and get dimensions even if it can't be seen.

Also prevented the expanded select from scrolling the container. It is not really needed as the drop-down has the constrain rules which will make it visible.

This is a workaround, until we can look at OptionList in more detail.

If anyone sees the blank Select after this has gone in, let me know!

@willmcgugan willmcgugan marked this pull request as draft November 20, 2024 15:18
@willmcgugan willmcgugan removed the request for review from darrenburns November 20, 2024 15:18
@willmcgugan
Copy link
Collaborator Author

This doesn't fix anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant