fix(tabbed content): prevent duplicate ids error #5216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Textualize#5215 where removing then adding a pane could crash with a `DuplicateIds` exception. Rather than assigning the ID based on the *current* tab count, this adds a `_cumulative_tab_count` to ensure added panes have a unique ID.
|
This doesn't fix the highlighting issue when tabs are removed (#5215 (comment)), but that should probably be a separate issue/PR. |
TomJGooding
deleted the
fix-tabbed-content-prevent-duplicate-ids-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5215 where removing then adding a pane could crash with a
DuplicateIdsexception.Rather than assigning the ID based on the current tab count, this adds a
_cumulative_tab_countto ensure added panes have a unique ID.Please review the following checklist.