Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow tooltips in maximize view #5088

Merged
merged 12 commits into from
Oct 7, 2024
Merged

Allow tooltips in maximize view #5088

merged 12 commits into from
Oct 7, 2024

Conversation

willmcgugan
Copy link
Collaborator

@willmcgugan willmcgugan commented Oct 3, 2024 •
edited
Loading

  • Include textual-system widgets (such as tooltips) in maximize view by default.
  • Allow default ALLOW_IN_MAXIMIZED_VIEW to be set on the App.

Fixes #5083

@willmcgugan willmcgugan marked this pull request as draft October 3, 2024 20:23
@willmcgugan willmcgugan marked this pull request as ready for review October 3, 2024 20:36
@willmcgugan willmcgugan marked this pull request as draft October 3, 2024 21:39
@willmcgugan willmcgugan marked this pull request as ready for review October 3, 2024 21:50
darrenburns
darrenburns approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@darrenburns darrenburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willmcgugan willmcgugan merged commit ded24b1 into main Oct 7, 2024
3 of 4 checks passed
@willmcgugan willmcgugan deleted the allow-maximize branch October 7, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darrenburns darrenburns darrenburns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tooltips stop appearing when a widget is maximized
2 participants
@willmcgugan @darrenburns