Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix is_transparent #5075

Merged
merged 2 commits into from
Oct 2, 2024
Merged

fix is_transparent #5075

merged 2 commits into from
Oct 2, 2024

Conversation

willmcgugan
Copy link
Collaborator

@willmcgugan willmcgugan commented Oct 1, 2024 •
edited
Loading

Fixes Color.is_transparent which had been broken since the ANSI update.

This in turn, fixes transparent backgrounds deferring to render() -- which surprisingly there were no snapshot tests for!

@willmcgugan willmcgugan merged commit 91046dc into main Oct 2, 2024
20 checks passed
@willmcgugan willmcgugan deleted the fix-color-transparent branch October 2, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darrenburns darrenburns darrenburns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willmcgugan @darrenburns