refreshing invisible widgets is a no-op #5063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavierog
reviewed
Sep 26, 2024
CHANGELOG.md
Outdated
| ## [0.81.0] - 2024-09-25 | ||
|
|
||
| ### Added | ||
|
|
||
| - Added `x_axis` and `y_axis` parameters to `Widget.scroll_to_region` https://github.com/Textualize/textual/pull/5047 | ||
| - Added `Tree.move_cursor_to_line` https://github.com/Textualize/textual/pull/5052 | ||
| - Added `DOMNode.is_on_screen` property |
|
@willmcgugan It's not clear to me if this is ready for review or not |
|
Is ready for review |
darrenburns
requested changes
Sep 30, 2024
Co-authored-by: Darren Burns <[email protected]>
Co-authored-by: Darren Burns <[email protected]>
Co-authored-by: Darren Burns <[email protected]>
Co-authored-by: Darren Burns <[email protected]>
darrenburns
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5056
Reverts the work in #5048
Looking a little deeper regarding the issues with auto_refresh. The problem was when an automatic refresh occurs on a widget hidden by virtue of a parent being hidden, it still reset some internal data structures in the compositor.
The fix was to make refreshing widgets not on the screen a true no-up, which negates the need for #5048 -- which was fixing an issue this update prevents from occurring.
Thanks for the MRE @xavierog