Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent error in TextArea constructor #5045

Merged
merged 6 commits into from
Sep 24, 2024
Merged

Conversation

willmcgugan
Copy link
Collaborator

@willmcgugan willmcgugan commented Sep 24, 2024

The TextArea was invoking code in the constructor that expected an active app.

Fixes #5042

@willmcgugan willmcgugan marked this pull request as draft September 24, 2024 10:44
@willmcgugan willmcgugan changed the title prevent error in constructor prevent error in TextArea constructor Sep 24, 2024
@willmcgugan willmcgugan marked this pull request as ready for review September 24, 2024 10:53
Copy link
Member

@darrenburns darrenburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming the tests pass :)

@willmcgugan willmcgugan merged commit c81df43 into main Sep 24, 2024
20 checks passed
@willmcgugan willmcgugan deleted the fix-textarea-construct branch September 24, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants