Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix error when exiting inline more prematurely #5039

Merged
merged 3 commits into from
Sep 24, 2024
Merged

fix error when exiting inline more prematurely #5039

merged 3 commits into from
Sep 24, 2024

Conversation

willmcgugan
Copy link
Collaborator

@willmcgugan willmcgugan commented Sep 23, 2024 •
edited
Loading

Fixes #5040

@willmcgugan willmcgugan marked this pull request as draft September 23, 2024 18:13
@willmcgugan willmcgugan changed the title WIP fix error when exiting inline more prematurely fix error when exiting inline more prematurely Sep 24, 2024
@willmcgugan willmcgugan marked this pull request as ready for review September 24, 2024 10:23
@willmcgugan willmcgugan merged commit c3e00ae into main Sep 24, 2024
20 checks passed
@willmcgugan willmcgugan deleted the inline-exit-fix branch September 24, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darrenburns darrenburns darrenburns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running self.exit() in on_mount() throws exception
2 participants
@willmcgugan @darrenburns