fix(app): fix inline_no_clear
#5022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmcgugan
reviewed
Sep 23, 2024
| @@ -2909,10 +2909,14 @@ async def invoke_ready_callback() -> None: | |||
| self._driver.write( | |||
| Control.move(-cursor_x, -cursor_y + 1).segment.text | |||
| ) | |||
| if inline_no_clear and not not self.app._exit_renderables: | |||
There was a problem hiding this comment.
The "not not" is a bug. I think the reasoning was that if there are errors (in the exit renderables) they should be printed rather than the last frame.
|
@TomJGooding Sorry for usurping your PR. This seems to give the results we are looking for (from experimentation) |
|
No problem. I did notice now running the example in issue #4882 leaves a bit of a gap before the start of the error message, but probably not really an issue.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5019.
I'm afraid I don't fully understand commit 8c01ef7, but this change seems to fix the broken
inline_no_clearwithout any regression related to issue #4882 which I believe this commit intended to fix.