Loosen platformdirs version requirement #4971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@darrenburns @willmcgugan hey guys, super sorry to bother! I am sure this isn't impacting your work so no worries nor rush on this, but if you have the time I'd much appreciate a review! Thanks for your time I appreciate it a lot. |
|
Hey @darrenburns I wonder if we can just vendor the relevant function and omit the dependency entirely? |
|
I had a look but it wasn't very self-contained. It depended on lots of other functions for checking environments and os IIRC |
|
Fair enough. It's a fairly small dependency anyway. |
JaceyPenny
force-pushed
the
jaceypenny/platformdirs-version
branch
from
633dc3d to
5f24a75
Compare
|
Rebased and re-locked against |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the following checklist.
See comment: #4875 (comment)