Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add key_to_character function #4945

Merged
merged 7 commits into from
Aug 28, 2024
Merged

Add key_to_character function #4945

merged 7 commits into from
Aug 28, 2024

Conversation

willmcgugan
Copy link
Collaborator

@willmcgugan willmcgugan commented Aug 27, 2024 •
edited
Loading

Fixes #4944 and #4930

TomJGooding
TomJGooding reviewed Aug 27, 2024
View reviewed changes
Copy link
Contributor

@TomJGooding TomJGooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, hope you don't mind me sticking my nose in but couldn't help spotting this while in spell check mode!

src/textual/dom.py Outdated Show resolved Hide resolved
src/textual/widgets/_input.py Outdated Show resolved Hide resolved
src/textual/widgets/_text_area.py Outdated Show resolved Hide resolved
@willmcgugan willmcgugan merged commit 1136f8d into main Aug 28, 2024
20 checks passed
@willmcgugan willmcgugan deleted the key-to-character branch August 28, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomJGooding TomJGooding TomJGooding left review comments

@darrenburns darrenburns darrenburns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check consume key doesn't cover everything
3 participants
@willmcgugan @darrenburns @TomJGooding