Fix scroll page #4916
Merged
Fix scroll page #4916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrenburns
reviewed
Aug 22, 2024
|
|
||
| def test_scroll_page_down(snap_compare): | ||
| """Regression test for https://github.com/Textualize/textual/issues/4914""" | ||
| # Should show 25 at the top |
There was a problem hiding this comment.
Just a reminder that if you write the comment in the docstring, it'll appear in the snapshot report now which is really handy if the test fails.
Also, you can inline the app if you want and just pass in the instance rather than putting it in a separate file.
darrenburns
requested changes
Aug 22, 2024
darrenburns
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4914