Disallow Screen instances in App.SCREENS
#4894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmcgugan
requested changes
Aug 18, 2024
|
Should be all done now, thanks! |
|
I think all the places where an instance was used in |
willmcgugan
requested changes
Aug 20, 2024
|
Sorry; I'll fix the merge conflicts sometime later today. |
|
Merge conflicts have been fixed! |
|
Are you really 16?! I figured you were already a pro. |
|
Yup! I've been doing this since I was ~9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @willmcgugan
Closes #4893.
It's worth noting that while implementing this, I discovered a second issue:
add_modeappends to theMODESclassvar, meaning it applies to all instances of theApp-- if this is the desired behavior, then it should probably be made a classmethod. Otherwise, maybe an attribute to hold per-instance modes?