Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow None in Screen callback #4795

Merged
merged 12 commits into from
Jul 24, 2024
Merged

allow None in Screen callback #4795

merged 12 commits into from
Jul 24, 2024

Conversation

willmcgugan
Copy link
Collaborator

@willmcgugan willmcgugan commented Jul 24, 2024 •
edited
Loading

Fixes #4790

Previously, calling Screen.dismiss with no arguments would not call the Screen callback. Now, it will call the callback with a None argument.

This feels like a more sensible default, as the dev can decide what to do with the screen result.

@willmcgugan willmcgugan changed the title allow None in callback allow None in Screen callback Jul 24, 2024
@willmcgugan willmcgugan marked this pull request as draft July 24, 2024 09:13
@willmcgugan willmcgugan marked this pull request as ready for review July 24, 2024 12:52
@willmcgugan willmcgugan merged commit bff8fbf into main Jul 24, 2024
20 checks passed
@willmcgugan willmcgugan deleted the screen-result branch July 24, 2024 16:05
@willmcgugan
Copy link
Collaborator Author

#executivedecision

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Screen.dismiss doesn't call the callback function if it's called with no args
1 participant
@willmcgugan