run commands regardless of the bindings checking order #4793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for reporting this and your PR. I've created issue #4794 to help track this with my attempt at an MRE, but please let me know if I've misunderstood the issue. It looks like this change causes a number of tests to fail which suggests this may not be the correct fix? |
|
Thanks, closing in favor of #4798 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a
Bindingis marked withpriority=True, it isn't clickable with the mouse because_check_bindingswill only run un-prioritized bindings. This removes the check and runs actions regardless of their priority status. I'm not sure why this check was there to begin with honestly, so hopefully I'm not breaking anything else.