Fixes for Input widget cursor visual glitches #4773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrenburns
changed the title
willmcgugan
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Inputwidget has a couple of annoying visual glitches relating to the cursor.This is another pass over it to ensure that the behaviour matches what you'd expect. When clicking the Input, the cursor no longer flickers to the end.
When you set the value in the Input widget for the first time, the cursor will go to the end of the value.
It also ensures that actions performed inside the Input result in the blink cycle being restarted. Previously it wouldn't go back to the beginning of the cycle and would again cause a weird delay before the cursor is visible.
Closes #4823