SelectionList events changes #4759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Its important for callers to know on a per-option basis if one was toggled, and is a reasonable expectation. Also update docs to reflect this..
willmcgugan
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures "Toggled" events are sent when bulk toggling via the API occurs.
Also explicitly defines semantics of "toggled" vs "changed" in the docstrings.
Toggled events only fire when the value is explicitly toggled via user interaction or a toggle method. Setting a value programmatically to a value that happens to be the opposite of the current value is not considered a "toggle", although it is considered a "change".