Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datatable): prevent crash with border link #4415

Merged
merged 4 commits into from
Apr 16, 2024
Merged

fix(datatable): prevent crash with border link #4415

merged 4 commits into from
Apr 16, 2024

Conversation

TomJGooding
Copy link
Contributor

@TomJGooding TomJGooding commented Apr 10, 2024 •
edited
Loading

Fixes #4410.

Please review the following checklist.

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)

@TomJGooding TomJGooding marked this pull request as ready for review April 12, 2024 12:37
darrenburns
darrenburns approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@darrenburns darrenburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Tom!

@darrenburns darrenburns merged commit 8320d07 into Textualize:main Apr 16, 2024
20 checks passed
@TomJGooding TomJGooding deleted the fix-datatable-prevent-crash-with-border-link branch April 16, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darrenburns darrenburns darrenburns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KeyError on DataTable border title link click
2 participants
@TomJGooding @darrenburns