added insert, pop and remove_items methods to ListView #4384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davep
reviewed
Apr 4, 2024
src/textual/widgets/_list_view.py
Outdated
| Returns: | ||
| An awaitable object that waits for the direct children to be removed. | ||
| """ | ||
| if len(self._nodes) == len(indices): |
There was a problem hiding this comment.
If there are two items in the ListView and the developer passed [0, 0] as the indices this will have unintended consequences.
There was a problem hiding this comment.
Thank for pointing it out! I have removed that block as it's not necessary.
willmcgugan
reviewed
Apr 10, 2024
src/textual/widgets/_list_view.py
Outdated
| """ | ||
| items_to_remove = [] | ||
| for index in indices: | ||
| items_to_remove.append(self.query("ListItem")[index]) |
There was a problem hiding this comment.
You could cache that query. Otherwise it would be performed once per loop.
There was a problem hiding this comment.
please have a review
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend ListView's methods to make it easier to work with ListView.
New methods are:
insert(): insert new items to ListView at specified indexpop(): remove last item from ListView or remove item at specified indexremove_items(): remove multiple items from ListView at specified indices