Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let mouse scroll events pass through disabled widgets #4297

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

davep
Copy link
Contributor

@davep davep commented Mar 14, 2024

All mouse events are stopped when they hit a disabled widget; this is mostly correct, except for mouse scroll events (scroll wheel, trackpad swipes, etc). This PR ensures that those particular events always pass through.

Fixes #4242.

@davep davep added bug Something isn't working Task labels Mar 14, 2024
@davep davep self-assigned this Mar 14, 2024
Copy link
Contributor

@rodrigogiraoserrao rodrigogiraoserrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐍 🚀

@davep davep merged commit 97cefa6 into Textualize:main Mar 15, 2024
20 checks passed
@davep davep deleted the scroll-through-disabled-widgets branch March 15, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabled widgets prevent mouse scrolling
2 participants