Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabbed content styling isolation #4283

Merged
merged 4 commits into from
Mar 12, 2024
Merged

Tabbed content styling isolation #4283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a7a0e3f
Make the styling of tabs in TabbedContent less leaky
davep Mar 12, 2024
a14586f
Add snapshot test
davep Mar 12, 2024
5dab133
Update the ChangeLog
davep Mar 12, 2024
19a9258
Merge branch 'main' into tabbed-content-styling-isolation
davep Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- Markdown component classes weren't refreshed when watching for CSS https://github.com/Textualize/textual/issues/3464
- Rename `Switch.action_toggle` to `action_toggle_switch` to fix clash with `DOMNode.action_toggle` https://github.com/Textualize/textual/issues/4262
- Fixed `OptionList.OptionHighlighted` leaking out of `Select` https://github.com/Textualize/textual/issues/4224
- Fixed a style leak from `TabbedContent` https://github.com/Textualize/textual/issues/4232

### Changed

Expand Down
7 changes: 3 additions & 4 deletions src/textual/widgets/_tabbed_content.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,12 +229,11 @@ class TabbedContent(Widget):
"""A container with associated tabs to toggle content visibility."""

DEFAULT_CSS = """

TabbedContent {
height: auto;
}
TabbedContent Tabs {
dock: top;
&> ContentTabs {
dock: top;
}
}
"""

Expand Down
Loading
Loading