-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable AppFocus
and AppBlur
in terminal emulators
#4265
Merged
Merged
Changes from 2 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
775d1b4
Add support for XTerm FocusIn/FocusOut detection
davep 2f13d7f
Fix a copy/paste snafu
davep 67b4d45
Simply use string comparison for FocusIn/Out checks
davep b96bc9a
Simply use string comparison for bracketed paste checks
davep d28596a
Add FocusIn/Out enable/disable support to the Windows driver
davep 497dc54
Fix the problem of the focused widget being lost when app focus goes
davep 68ac360
Merge branch 'main' into more-app-focus-blur
davep faea8fa
Only restore widget focus if the widget belongs to the current screen
davep 8c18c9e
Add tests for AppFocus and AppBlur
davep f148e1f
Merge branch 'main' into more-app-focus-blur
davep 11fbf4f
Update the docstrings of AppFocus and AppBlur
davep a687be9
Update the ChangeLog
davep 4bb9b59
Don't restore focus on AppFocus if something has focus
davep 02e9109
Merge branch 'main' into more-app-focus-blur
davep c768beb
Add a snapshot test for AppBlur
davep File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like this needs to be a regex. Could it not be a simple string?
Ditto for the bracketed paste stuff. Unless I'm missing something, it looks like they could also just be strings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to ask you that very question in the morning, oddly enough. Couldn't for the life of me see why the bracketed paste checking used a regex but followed the pattern with a mental note to ask why it was done that way (although looking at fe151a7 it seems I'd have been asking the wrong person anyway).
If there was no reason I'll make them simple strings; makes way more sense to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably just following a pattern. But yeah, let's go with strings. And if you wouldn't mind changing the bracketed paste ones while you are there...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do.