fix(tree-sitter): remove slow html highlight patterns #4195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Textualize#4152 by removing all `((element (start_tag (tag_name) @_tag)` patterns from the `html.scm` highlights query file. These patterns will cause a segfault on relatively large documents and even just one seems a massively expensive operation from some quick testing. All tests pass after removing these and I couldn't see they were actually used anywhere in syntax highlighting, but please correct me if I'm wrong!
…tter-remove-slow-html-highlight-patterns
|
Much appreciated, @TomJGooding ! |
|
Very nice work on this, thank you! |
|
No problem, glad I can contribute occasionally rather than just being a nuisance! |
TomJGooding
deleted the
fix-tree-sitter-remove-slow-html-highlight-patterns
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4152 by removing all
((element (start_tag (tag_name) @_tag)patterns from thehtml.scmhighlights query file.These patterns will cause a segfault on relatively large documents and even just one seems a massively expensive operation from some quick testing.
All tests pass after removing these and I couldn't see they were actually used anywhere in syntax highlighting, but please correct me if I'm wrong!
Please review the following checklist.