Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(text area)!: stop escape shifting focus if default tab behaviour #4125

Conversation

TomJGooding
Copy link
Contributor

@TomJGooding TomJGooding commented Feb 5, 2024

Fixes #4110.

Please review the following checklist.

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)

@TomJGooding TomJGooding marked this pull request as ready for review February 5, 2024 20:58
Copy link
Member

@darrenburns darrenburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion, but looks good. Thanks!

docs/widgets/text_area.md Outdated Show resolved Hide resolved
@darrenburns
Copy link
Member

Also, for the CHANGELOG I think it'll go into the "Fixed" section, and noted as a breaking change.

@TomJGooding TomJGooding changed the title fix(text area): stop escape shifting focus if default tab behaviour fix(text area)! stop escape shifting focus if default tab behaviour Feb 6, 2024
@TomJGooding TomJGooding changed the title fix(text area)! stop escape shifting focus if default tab behaviour fix(text area)!: stop escape shifting focus if default tab behaviour Feb 6, 2024
@TomJGooding
Copy link
Contributor Author

TomJGooding commented Feb 6, 2024

Done - I struggled with wording the changelog entry so hope that is okay!

(Also fixed where it looks like the changelog was out-of-sync after latest update)

@darrenburns
Copy link
Member

Thanks!

@darrenburns darrenburns merged commit e27c41c into Textualize:main Feb 7, 2024
20 checks passed
@TomJGooding TomJGooding deleted the fix-text-area-stop-escape-shifting-focus-if-default-tab-behaviour branch February 7, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TextArea still uses Escape to move focus on
2 participants