Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only perform the SIGTOU check in the Linux driver when hooked up to a tty #4105

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

davep
Copy link
Contributor

@davep davep commented Feb 2, 2024

Fixes #4104.

Tagging @pablogsal for review (and thanks for the report/test of the issue).

@davep davep added bug Something isn't working Task labels Feb 2, 2024
@davep davep self-assigned this Feb 2, 2024
Copy link
Contributor

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davep
Copy link
Contributor Author

davep commented Feb 2, 2024

@willmcgugan if we do manage a point release this weekend; might be worth rolling this as well as #4103 into it.

@willmcgugan
Copy link
Collaborator

Thanks @davep @pablogsal Point release coming soon.

@willmcgugan willmcgugan merged commit be21e4d into Textualize:main Feb 2, 2024
20 checks passed
@davep davep deleted the fix-4104 branch February 2, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in Textual 0.48 when executing app in a subprocess
3 participants