Signal #4012
Signal #4012
Conversation
| @@ -248,11 +248,14 @@ def get_token(self, expect: Expect) -> Token: | |||
| line = self.lines[line_no] | |||
| match = expect.match(line, col_no) | |||
| if match is None: | |||
| error_line = line[col_no:].rstrip() | |||
There was a problem hiding this comment.
Slight tweak to formatting. Checks if there is a semi-colon at the end of the line, before suggesting it.
|
@davep You may be able to use the Signal mechanism herein for the suspend resume notification. |
Any suggestions for an alernative? |
| @@ -77,7 +77,7 @@ def __init_subclass__( | |||
| cls.handler_name = f"on_{namespace}_{name}" if namespace else f"on_{name}" | |||
|
|
|||
| @property | |||
| def control(self) -> Widget | None: | |||
| def control(self) -> DOMNode | None: | |||
There was a problem hiding this comment.
Possibly want to tweak the docstring to say node rather than widget now; or from the "end user" point of view does the intent of the property remain the same? (we want them to think about widgets)
There was a problem hiding this comment.
Yeah, might leave it as widget in the docs. It's more meaningful for the average user.
| if callback not in callbacks: | ||
| callbacks.append(callback) | ||
|
|
||
| def unsubscribe(self, node: DOMNode) -> None: |
There was a problem hiding this comment.
As I read the interface, it seems you can subscribe multiple callbacks from a single node, but on the other hand you can only unsubscribe a node (presumably unsubscribing every callback). Is that a correct reading and is that intentional?
There was a problem hiding this comment.
That's intentional. It's more to clean up all subscriptions on a node. If its a requirement, we can do something more finely grained later.
Co-authored-by: Dave Pearson <[email protected]>
This is mainly for a new Signal class, and also some fixes / new method