Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a better method of changing the label of a
Tab
; fixes #3901.This is a fairly small change, which turns
Tab.label
into a safe way of setting a new label for aTab
. So the question in the original issue would end up being answered with this:It also quietly supports going via
Tab.update
too but doesn't advertise it as the approach to take.The PR also, of course, addresses the issue of the underline not redrawing correctly.
Screen.Recording.2024-01-08.at.15.52.31.mov