calculate message namespace from __qualname__ when not specified #3940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmcgugan
reviewed
Mar 19, 2024
| else: | ||
| # a class defined inside of a function will have a qualified name like func.<locals>.Class, | ||
| # so make sure we only use the actual class name(s) | ||
| qualname = cls.__qualname__.rsplit("<locals>.", 1)[-1] |
There was a problem hiding this comment.
This seem brittle. Is it guaranteed that CPython and all other Python's will have a qualname formatted like this?
There was a problem hiding this comment.
It's explicitly defined in the PEP that introduced __qualname__: https://peps.python.org/pep-3155/#proposal
|
Sorry for the delay on this - this is quite the gotcha! I've confirmed it fixes the issue and tested it in a complex app. I also updated the CHANGELOG. If the tests pass I think we're good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3939
Use
__qualname__for the message namespace since it already contains the outer class, making thehandler_nameprocessing in_MessagePumpMetaunnecessaryPlease review the following checklist.