Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget.loading scroll-related glitch fixes #3813

Closed
wants to merge 5 commits into from

Conversation

davep
Copy link
Contributor

@davep davep commented Dec 5, 2023

This PR addresses a couple of issues when using Widget.loading to show a loading indicator on a widget:

  • If the scrollbar gutter was fixed, it would cause some of the background widget to show through.
  • If the underlying widget was scrollable, and was scrolled down some way, the loading indicator would either be partially visible or not visible at all.

Fixes #3733.

@davep davep added bug Something isn't working Task labels Dec 5, 2023
@davep davep self-assigned this Dec 5, 2023
@davep davep changed the title Widget.loading scroll-related glitch fixex Widget.loading scroll-related glitch fixes Dec 5, 2023
@davep davep marked this pull request as ready for review December 5, 2023 14:54
Copy link
Collaborator

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about this some more. Why can't the loading overlay simply cover the scrollbar and gutter?

That might negate the need for this _widget_state weak dict.

@davep
Copy link
Contributor Author

davep commented Dec 5, 2023

As per in-person discussion, handing this off to @willmcgugan for a wee play to consider some alternative methods of doing this type of overlay.

@davep
Copy link
Contributor Author

davep commented Dec 5, 2023

Closing in favour of #3816.

@davep davep closed this Dec 5, 2023
@davep davep deleted the the-white-zone branch December 5, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scrollbar-gutter causes loading overlay to not fully overlay
2 participants