Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pause a moment longer when testing the command palette no-matches timeout #3708

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Pause a moment longer when testing the command palette no-matches timeout #3708

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01cfdf8
Add some wiggle room to the no-matches command palette timeout test
davep Nov 20, 2023
43de6d7
Merge branch 'Textualize:main' into main
davep Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/command_palette/test_no_results.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@ async def test_no_results() -> None:
assert results.visible is False
assert results.option_count == 0
await pilot.press("a")
await pilot.pause(delay=CommandPalette._NO_MATCHES_COUNTDOWN)
# https://github.com/Textualize/textual/issues/3700 -- note the
# little bit of wiggle room to allow for Windows.
await pilot.pause(delay=CommandPalette._NO_MATCHES_COUNTDOWN + 0.1)
assert results.visible is True
assert results.option_count == 1
assert "No matches found" in str(results.get_option_at_index(0).prompt)
Expand Down
Loading