-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
input restriction #3657
Merged
Merged
input restriction #3657
Changes from 17 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
8d2c3d8
input restriction
willmcgugan 492867e
types
willmcgugan 86a1f15
tweak
willmcgugan 6ca9caf
tests
willmcgugan b5bbb0b
docstring
willmcgugan 67d4299
fix lock
willmcgugan 605e71a
words
willmcgugan ef6ba21
add valid empty
willmcgugan 2b5aa74
another test
willmcgugan 8a1c7d0
fix regex
willmcgugan 45e1714
doc
willmcgugan 00e2af5
name change
willmcgugan 3a31582
Fix regex
willmcgugan ec37edb
force initial value
willmcgugan 45c3737
force reactive
willmcgugan d180368
test fix
willmcgugan 9e2320f
add plus
willmcgugan b47574d
input type literal
willmcgugan 4ae679a
export InputType
willmcgugan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
from textual.app import App, ComposeResult | ||
from textual.widgets import Input | ||
|
||
|
||
class InputApp(App): | ||
def compose(self) -> ComposeResult: | ||
yield Input(placeholder="An integer", type="integer") | ||
yield Input(placeholder="A number", type="number") | ||
|
||
|
||
if __name__ == "__main__": | ||
app = InputApp() | ||
app.run() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A string of length 0 is a perfectly fine string.
If
max_length
can be set toNone
to mean "No restriction", it'd feel cleaner if we lifted the restriction on the number needing to be> 0
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it is paradoxical to have an input with a max length of 0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree it doesn't sound useful but my lack of imagination shouldn't deter us from implementing things :P