Chunk writes on Windows #3644
Merged
Chunk writes on Windows #3644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is experimental. I think, ideally, we'll do this by finding an optimal buffer size and writing based on that, but for the moment let's just try line-by-line as that's easy. This will be used to test against the tool I've made that lets me recreate the issue documented in Textualize#2548; if this does the job we'll take this further.
First we tested this by splitting the output by lines; that worked but it could be faster. So now we're going to take the problematic buffer size (32KiB), assume a reasonable worst case of every character heading out being 3 bytes in size, and chunking the output based on that. In other words, experiment for Textualize#2548 take two.
willmcgugan
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2548 by adding a workaround for python/cpython#82052.