Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(notifications): add link styles #3531

Merged
merged 1 commit into from
Oct 24, 2023
Merged

fix(notifications): add link styles #3531

merged 1 commit into from
Oct 24, 2023

Conversation

TomJGooding
Copy link
Contributor

Fixes #3530 by adding link styles (copied from Widget) to the Toast widget.

Please review the following checklist.

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)

darrenburns
darrenburns approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@darrenburns darrenburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@darrenburns darrenburns merged commit a413ee7 into Textualize:main Oct 24, 2023
22 checks passed
@TomJGooding TomJGooding deleted the fix-notifications-add-link-styles branch October 24, 2023 17:36
rodrigogiraoserrao added a commit that referenced this pull request Oct 25, 2023
@rodrigogiraoserrao
Fix notifications CSS.
7b70b9a 
This was merged more or less at the same time as 'initial' was added to CSS but the tests weren't ran with that change.
Related PRs: #3566, #3531.
rodrigogiraoserrao added a commit that referenced this pull request Oct 25, 2023
@rodrigogiraoserrao
Fix notifications CSS.
87274cb 
This was merged more or less at the same time as 'initial' was added to CSS but the tests weren't ran with that change.
Related PRs: #3566, #3531.
@rodrigogiraoserrao rodrigogiraoserrao mentioned this pull request Oct 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darrenburns darrenburns darrenburns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing link styles in Toast notifcations
2 participants
@TomJGooding @darrenburns