Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow scrollbar size of zero (scrollable containers without scrollbars) #3488

Merged
merged 5 commits into from
Oct 10, 2023
Merged

Allow scrollbar size of zero (scrollable containers without scrollbars) #3488

merged 5 commits into from
Oct 10, 2023

Conversation

darrenburns
Copy link
Member

@darrenburns darrenburns commented Oct 9, 2023 •
edited
Loading

Scrollbar size can be set to zero for a scrollable container with no visible scrollbars.

@darrenburns darrenburns marked this pull request as ready for review October 10, 2023 09:23
@rodrigogiraoserrao rodrigogiraoserrao linked an issue Oct 10, 2023 that may be closed by this pull request
Allow setting a scrollbar's size to 0 #3482
Closed
rodrigogiraoserrao
rodrigogiraoserrao reviewed Oct 10, 2023
View reviewed changes
Copy link
Contributor

@rodrigogiraoserrao rodrigogiraoserrao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good but I'd expect a snapshot test and a test that makes sure scrolling is actually possible.
(These two could be the same.)

@darrenburns
Copy link
Member Author

@rodrigogiraoserrao gonna leave the additional tests for now and merge this to get it into the release we're doing now.

@darrenburns darrenburns merged commit 1a0cd77 into main Oct 10, 2023
22 checks passed
@darrenburns darrenburns deleted the scrollbar-zero-size branch October 10, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigogiraoserrao rodrigogiraoserrao rodrigogiraoserrao left review comments

@willmcgugan willmcgugan willmcgugan approved these changes

@davep davep Awaiting requested review from davep

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow setting a scrollbar's size to 0
3 participants
@darrenburns @willmcgugan @rodrigogiraoserrao