Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DataTable crash when removing and updating cell at the same time #3487

Merged
merged 4 commits into from
Oct 9, 2023
Merged

Fix DataTable crash when removing and updating cell at the same time #3487

merged 4 commits into from
Oct 9, 2023

Conversation

darrenburns
Copy link
Member

@darrenburns darrenburns commented Oct 9, 2023 •
edited
Loading

As per title. There was a crash when you tried to remove a row/column and also update a cell within a short period.

  • The logic for updating dimensions after removing a row runs in on_idle.
  • When you tried to update a cell that was in this now removed row on_idle wasn't informed that the cell was removed in the time since check_idle was called.
  • Now we update the data structure that on_idle uses to know what cell dimensions to recompute before it runs.

Please review the following checklist.

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)

@darrenburns darrenburns marked this pull request as ready for review October 9, 2023 13:17
@darrenburns darrenburns merged commit 4054667 into main Oct 9, 2023
22 checks passed
@darrenburns darrenburns deleted the datatable-crash-fix branch October 9, 2023 13:58
@rodrigogiraoserrao rodrigogiraoserrao linked an issue Oct 9, 2023 that may be closed by this pull request
DataTable crash #3470
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willmcgugan willmcgugan willmcgugan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DataTable crash
2 participants
@darrenburns @willmcgugan